Hi Paul, maybe it would be a good idea to add a `0/7` mail that describes the overall goal of this patch series, much like a Pull Request? I found it very useful -- even for myself -- to set a description via `git branch --edit-description` and to let `git format-patch` use that via the `--cover-letter` option.
below just two minor nits because the rest of the patches looks fine to me: On 2015-04-12 09:46, Paul Tan wrote: > diff --git a/cache.h b/cache.h > index 3d3244b..7f9bab0 100644 > --- a/cache.h > +++ b/cache.h > @@ -836,6 +836,13 @@ char *strip_path_suffix(const char *path, const > char *suffix); > int daemon_avoid_alias(const char *path); > extern int is_ntfs_dotgit(const char *name); > > +/** > + * Returns the newly allocated string "$XDG_CONFIG_HOME/git/%s". If > + * $XDG_CONFIG_HOME is unset or empty, returns the newly allocated string > + * "$HOME/.config/git/%s". Returns NULL if an error occurred. > + */ > +extern char *xdg_config_home(const char *fn); Should this not be inserted close to home_config_paths()? Also, the name "fn" sounds more like "function" than like "filename" to me, especially keeping the name `config_fn_t` in mind. Maybe call the parameter "filename" to avoid confusion? Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
