scwhittle commented on code in PR #38297:
URL: https://github.com/apache/beam/pull/38297#discussion_r3152789438
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillWatermarkHold.java:
##########
@@ -72,6 +72,9 @@ public class WindmillWatermarkHold extends WindmillState
implements WatermarkHol
@Override
public void clear() {
+ if (cachedValue != null && !cachedValue.isPresent() && localAdditions ==
null) {
Review Comment:
How about:
localAdditions = null;
if (cachedValue == null || cachedValue.isPresent()) {
cleared = true;
cachedValue = Optional.absent();
}
no reason to not skip sending backend clear if there were localadditions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
