gemini-code-assist[bot] commented on code in PR #38368:
URL: https://github.com/apache/beam/pull/38368#discussion_r3185243420


##########
CHANGES.md:
##########
@@ -69,6 +69,7 @@
 
 ## New Features / Improvements
 
+* Added support for setting disk provisioned IOPS and throughput in Dataflow 
runner via `--diskProvisionedIops` and `--diskProvisionedThroughputMibps` 
pipeline options (Java/Go) 
([#38349](https://github.com/apache/beam/issues/38349)).

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   The entry mentions support for Java and Go, but this pull request also adds 
support for the Python SDK. Additionally, the flag names for Python and Go use 
snake_case (`--disk_provisioned_iops` and 
`--disk_provisioned_throughput_mibps`) rather than the camelCase shown. 
Consider updating the description to include Python and use more general 
language for the option names to cover all SDKs.
   
   ```suggestion
   * Added support for setting disk provisioned IOPS and throughput in Dataflow 
runner via disk provisioned IOPS and throughput pipeline options 
(Java/Go/Python) ([#38349](https://github.com/apache/beam/issues/38349)).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to