derrickaw commented on code in PR #38362:
URL: https://github.com/apache/beam/pull/38362#discussion_r3185330328
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -534,6 +561,171 @@ def
temp_pubsub_emulator(project_id="apache-beam-testing"):
yield created_topic_object.name
+class DatadogContainer(DockerContainer):
+ """
+ DatadogContainer starts a Datadog agent container for integration tests.
+ It exposes ports for DogStatsD (metrics) and the trace agent (APM).
+ """
+ def __init__(self, image="datadog/agent:latest"):
+ super().__init__(image)
+ self.statsd_port = 8125
+ self.trace_port = 8126
+ # An API key is required, but for local testing against the agent,
+ # it doesn't have to be a valid one.
+ self.with_env("DD_API_KEY", "dummy_key_for_testing")
+ # Redirect agent's own telemetry to prevent 403 errors from the real site
+ self.with_env("DD_DD_URL", "http://localhost:1234";)
+ # Disable log collection for test purposes to reduce noise
+ self.with_env("DD_LOGS_ENABLED", "true")
+ self.with_exposed_ports(self.statsd_port, self.trace_port)
+
+ def start(self):
+ super().start()
+ # Wait for the agent to be ready to receive traces and metrics.
+ # "Agent started" indicates the core agent is up.
+ # Disabling this wait as the container is reported as healthy and
+ # this specific log might not appear with dummy URLs.
+ # wait_for_logs(self, "Agent started", timeout=120)
+ return self
+
+ def get_statsd_host(self):
+ return self.get_container_host_ip()
+
+ def get_statsd_port(self):
+ return self.get_exposed_port(self.statsd_port)
+
+ def get_trace_agent_host(self):
+ return self.get_container_host_ip()
+
+ def get_trace_agent_port(self):
+ return self.get_exposed_port(self.trace_port)
+
+ def get_api_key(self):
+ return "dummy_key_for_testing"
+
+ def get_logs_url(self):
+ # The trace agent and logs agent listen on the same port by default
+ return \
+ f"http://{self.get_container_host_ip()}:{self.get_trace_agent_port()}"
Review Comment:
not true; there is a 80 character lint limit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
