gemini-code-assist[bot] commented on code in PR #38371:
URL: https://github.com/apache/beam/pull/38371#discussion_r3188095627


##########
sdks/python/apache_beam/yaml/yaml_io.py:
##########
@@ -563,6 +563,7 @@ def write_to_iceberg(
     drop: Optional[Iterable[str]] = None,
     only: Optional[str] = None,
     distribution_mode: Optional[str] = None,
+    autosharding: Optional[bool] = None,

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   Since the documentation states that `autosharding` is only available with 
the `hash` distribution mode, consider adding a validation check in the 
function body to enforce this constraint. This will provide a clearer error 
message to the user if an invalid combination is provided in the YAML 
configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to