gemini-code-assist[bot] commented on code in PR #38372:
URL: https://github.com/apache/beam/pull/38372#discussion_r3189060264
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/ValueInSingleWindow.java:
##########
@@ -154,13 +156,13 @@ public void encode(
@Override
public ValueInSingleWindow<T> decode(InputStream inStream) throws
IOException {
- return decode(inStream, Coder.Context.NESTED);
+ return decode(inStream, org.apache.beam.sdk.coders.Coder.Context.NESTED);
}
@Override
@SuppressWarnings("IgnoredPureGetter")
- public ValueInSingleWindow<T> decode(InputStream inStream, Coder.Context
context)
- throws IOException {
+ public ValueInSingleWindow<T> decode(
+ InputStream inStream, org.apache.beam.sdk.coders.Coder.Context
context) throws IOException {
Review Comment:
The formatting of the `decode` method signature is inconsistent with the
`encode` method in the same class. For better readability and adherence to
consistent wrapping practices, each parameter and the `throws` clause should be
placed on its own line when the signature is split. This also avoids an
unnecessarily long line.
```suggestion
public ValueInSingleWindow<T> decode(
InputStream inStream,
org.apache.beam.sdk.coders.Coder.Context context)
throws IOException {
```
<details>
<summary>References</summary>
1. According to the Google Java Style Guide, when a method declaration does
not fit on a single line, each parameter is typically placed on its own line
with a consistent indentation (usually 8 spaces for wrapped parameters). The
'throws' clause should also be consistently wrapped to maintain readability.
<sup>([link](http://console.cloud.google.com/gemini-code-assist/agents-tools))</sup>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
