Abacn commented on code in PR #38369: URL: https://github.com/apache/beam/pull/38369#discussion_r3197577863
########## sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/BatchElements.java: ########## @@ -0,0 +1,600 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.transforms; Review Comment: I wonder whether Java core or `sdks/java/extensions` fits better for this utility transform. Could https://github.com/apache/beam/tree/master/sdks/java/extensions/combiners be a good place for BatchElement to live? In this case we are less restricted to introduce light-weight third party dependencies, as we can use apache-commons-math: https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/stat/regression/SimpleRegression.html and also can run unit test with direct runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
