Hello,

I'm starting to play with skylift, and I have a small question
regarding the sorting function for patch files in build/mk/bsd.pkg.mk.
Namely,
patch_sort() {
    $SED -e '/^.*-\*/ d' |
    $SED -e 's/^\(.*\)-\([^-]*\)$/\1-\2 \2/' |
    LC_ALL=C $SORT -k 2 |
    $SED -e 's/^\([^ ]\+\) .*$/\1/'
}
will sort against what follows the last - in the filenames. This seems
at odds with what is written in godi's user manual, that says that
    the file names of patches have the convention
patch-<letter><letter>-<info>

Shouldn't the regexp in the second line of patch sort be something like:

 $SED -e 's/^\([^-]*\)-\(.*\)$/\1-\2 \2/' |

? This would allow to have something other than patch as a prefix
while retaining compatibility with the current convention.

Best regards,
-- 
E tutto per oggi, a la prossima volta
Virgile
_______________________________________________
Godi-list mailing list
Godi-list@ocaml-programming.de
https://godirepo.camlcity.org/mailman/listinfo/godi-list

Reply via email to