[gwt-contrib] RR: make HTTPRequestImplIE6 try to gracefully fallback when building its XHR

[Alex Rudnick]

Hey Joel :)

Would you take a look at this patch for HTTPRequestImplIE6?

In the case where there's a native XMLHttpRequest on the window object
(IE7), we'll use that, and failing that (IE6), we'll first try
"MSXML2.XMLHTTP.3.0" (recommended over on MSDN) and finally
"Microsoft.XMLHTTP".

I've seen "Microsoft.XMLHTTP" cause the elusive "POST when you asked
for a GET" bug, but haven't been able to reproduce recently; maybe we
got an update to fix it.

Thanks!

-- 
Alex Rudnick
swe, gwt, atl

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---


Index: user/src/com/google/gwt/user/client/impl/HTTPRequestImplIE6.java
===================================================================
--- user/src/com/google/gwt/user/client/impl/HTTPRequestImplIE6.java	(revision 3698)
+++ user/src/com/google/gwt/user/client/impl/HTTPRequestImplIE6.java	(working copy)
@@ -24,6 +24,14 @@
 
   @Override
   protected native JavaScriptObject doCreateXmlHTTPRequest() /*-{
-    return new ActiveXObject("Microsoft.XMLHTTP");
+    if ($wnd.XMLHttpRequest) {
+      return new XMLHttpRequest();
+    } else {
+      try {
+        return new ActiveXObject('MSXML2.XMLHTTP.3.0');
+      } catch (e) {
+        return new ActiveXObject("Microsoft.XMLHTTP");
+      }
+    }
   }-*/;
 }