Looks good. A small comment inline > diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c > index 731c07c29..5db504e6e 100644 > --- a/grub-core/kern/main.c > +++ b/grub-core/kern/main.c > @@ -265,6 +265,11 @@ reclaim_module_space (void) > void __attribute__ ((noreturn)) > grub_main (void) > { > +#ifdef GRUB_STACK_PROTECTOR > + /* This call can only be made from a function that does not return. */ Please add a bit of reasoning here not just in the commit message
-- Regards Vladimir 'phcoder' Serbinenko _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel