Generally looks ok but there are few comments like using err_t as a boolean with inverted semantics is unintuitive. Check for grub_malloc return value is completely missing. Goto is discouraged. Can you send using git send to the ML so it can be reviewed properly?
Le jeu. 24 avr. 2025, 15:44, Yair Yarom <ir...@cs.huji.ac.il> a écrit : > Hi, > > Sure, I've uploaded my changes to github: > https://github.com/irush-cs/grub/tree/irush/testpci > > Generally, this is a 'testpci' command that accepts one or more PCI device > IDs in the form "xxxx:yyyy" as arguments, or reads lines from a file given > by the --file parameter, and returns true if one or more of those PCI > devices is present, and false otherwise. > > Thanks, > Yair. > > > > On Wed, 23 Apr 2025 at 18:13, Vladimir 'phcoder' Serbinenko < > phco...@gmail.com> wrote: > >> Hello. Such a functionality would be beneficial for GRUB. For more >> details I'd have to see at least the proposed interface if not the actual >> patches >> >> Regards >> Vladimir 'phcoder' Serbinenko >> >> Le mer. 23 avr. 2025, 11:56, Yair Yarom <ir...@cs.huji.ac.il> a écrit : >> >>> Hi, >>> >>> We have a netboot environment, and for some machines we need to add >>> different kernel parameters (or different initrd) according to specific >>> devices - usually network devices, iommu, etc. things that cannot be tuned >>> after the kernel is up. >>> >>> For this we developed a 'testpci' grub command that can be used as an >>> 'if' condition test. Is this of any interest to the community? I'm not sure >>> what's the proper method for sending such ideas/patches. >>> >>> Regards, >>> Yair. >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> https://lists.gnu.org/mailman/listinfo/grub-devel >>> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
