Revision: 1586
          http://gtkpod.svn.sourceforge.net/gtkpod/?rev=1586&view=rev
Author:   jcsjcs
Date:     2007-06-23 04:23:23 -0700 (Sat, 23 Jun 2007)

Log Message:
-----------
        * src/file.c (copy_new_info): further simplification by using
          track_copy_item() instead of duplicating code.

Modified Paths:
--------------
    gtkpod/trunk/ChangeLog_detailed
    gtkpod/trunk/src/file.c

Modified: gtkpod/trunk/ChangeLog_detailed
===================================================================
--- gtkpod/trunk/ChangeLog_detailed     2007-06-23 10:53:23 UTC (rev 1585)
+++ gtkpod/trunk/ChangeLog_detailed     2007-06-23 11:23:23 UTC (rev 1586)
@@ -14,10 +14,13 @@
          thumbnail through libgpod and not from thumbnail filenames
          because these are not always set.
 
-       * src/deatils.c (details_button_apply_clicked): write tags
+       * src/details.c (details_button_apply_clicked): write tags
           back to file if option is selected. Change modification time
           of changed tracks.
 
+       * src/file.c (copy_new_info): further simplification by using
+         track_copy_item() instead of duplicating code.
+
 2007-06-22 Jorg Schuler <jcsjcs at users.sourceforge.net>
 
        * src/mp3file.c:

Modified: gtkpod/trunk/src/file.c
===================================================================
--- gtkpod/trunk/src/file.c     2007-06-23 10:53:23 UTC (rev 1585)
+++ gtkpod/trunk/src/file.c     2007-06-23 11:23:23 UTC (rev 1586)
@@ -820,93 +820,48 @@
        case T_SORT_ALBUMARTIST:
        case T_SORT_COMPOSER:
        case T_SORT_TVSHOW:
-           fromcp = track_get_item_pointer (from, item);
-           tocp = track_get_item_pointer (to, item);
-           g_free (*tocp);
-           *tocp = g_strdup (*fromcp);
-           break;
-       case T_GROUPING:
-       case T_CATEGORY:
-           /* not implemented from tags */
-           break;
-       case T_RATING:
-       case T_REMEMBER_PLAYBACK_POSITION:
-       case T_SKIP_WHEN_SHUFFLING:
-       case T_CHECKED:
-       case T_TIME_PLAYED:
-       case T_IPOD_PATH:
-       case T_ALL:
-       case T_IPOD_ID:
-       case T_TRANSFERRED:
-       case T_PLAYCOUNT:
-       case T_VOLUME:
-           /* not applicable */
-           break;
        case T_YEAR:
-           g_free (eto->year_str);
-           eto->year_str = g_strdup (efrom->year_str);
-           to->year = from->year;
-           break;
        case T_TRACK_NR:
-           to->track_nr = from->track_nr;
-           to->tracks = from->tracks;
-           break;
        case T_SIZE:
-           to->size = from->size;
-           break;
        case T_TRACKLEN:
-           to->tracklen = from->tracklen;
-           break;
        case T_STARTTIME:
-           to->starttime = from->starttime;
-           break;
        case T_STOPTIME:
-           to->stoptime = from->stoptime;
-           break;
        case T_BITRATE:
-           to->bitrate = from->bitrate;
-           break;
        case T_SAMPLERATE:
-           to->samplerate = from->samplerate;
-           break;
        case T_BPM:
-           to->BPM = from->BPM;
-           break;
        case T_TIME_ADDED:
-           to->time_added = from->time_added;
-           break;
        case T_TIME_MODIFIED:
-           to->time_modified = from->time_modified;
-           eto->mtime = efrom->mtime;
-           break;
        case T_TIME_RELEASED:
-           to->time_released = from->time_released;
-           break;
        case T_SOUNDCHECK:
-           to->soundcheck = from->soundcheck;
-           break;
        case T_CD_NR:
-           to->cd_nr = from->cd_nr;
-           to->cds = from->cds;
-           break;
        case T_COMPILATION:
-           to->compilation = from->compilation;
-           break;
        case T_MEDIA_TYPE:
-           to->mediatype = from->mediatype;
-           break;
        case T_SEASON_NR:
-           to->season_nr = from->season_nr;
-           break;
        case T_EPISODE_NR:
-           to->episode_nr = from->episode_nr;
+       case T_GROUPING:
+           track_copy_item (from, to, item);
            break;
+       case T_CATEGORY:
+           /* not implemented from tags */
+           break;
+       case T_RATING:
+       case T_REMEMBER_PLAYBACK_POSITION:
+       case T_SKIP_WHEN_SHUFFLING:
+       case T_CHECKED:
+       case T_TIME_PLAYED:
+       case T_IPOD_PATH:
+       case T_ALL:
+       case T_IPOD_ID:
+       case T_TRANSFERRED:
+       case T_PLAYCOUNT:
+       case T_VOLUME:
+           /* not applicable */
+           break;
        case T_ITEM_NUM:
            g_return_if_reached ();
        }
     }
 
-
     g_free (eto->thumb_path_locale);
     eto->thumb_path_locale = g_strdup (efrom->thumb_path_locale);
 


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2

Reply via email to