Revision: 1609
http://gtkpod.svn.sourceforge.net/gtkpod/?rev=1609&view=rev
Author: jcsjcs
Date: 2007-06-29 07:42:54 -0700 (Fri, 29 Jun 2007)
Log Message:
-----------
* src/details.c (details_setup_widget): fixed memory leak
(thanks to Daniele).
* src/display_coverart.c (coverart_set_images): fixed memory
leak (thanks to Daniele).
Modified Paths:
--------------
gtkpod/trunk/ChangeLog_detailed
gtkpod/trunk/src/details.c
gtkpod/trunk/src/display_coverart.c
Modified: gtkpod/trunk/ChangeLog_detailed
===================================================================
--- gtkpod/trunk/ChangeLog_detailed 2007-06-28 10:46:59 UTC (rev 1608)
+++ gtkpod/trunk/ChangeLog_detailed 2007-06-29 14:42:54 UTC (rev 1609)
@@ -1,9 +1,17 @@
+2007-06-25 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
+ * src/details.c (details_setup_widget): fixed memory leak
+ (thanks to Daniele).
+
+ * src/display_coverart.c (coverart_set_images): fixed memory
+ leak (thanks to Daniele).
+
2007-06-27 P.G. Richardson <phantom_sf at users.sourceforge.net>
- * gtkpod.glade:
+ * data/gtkpod.glade:
Changed fetchcover dialog's buttons to display icons only.
- * fetchcover.c:
+ * src/fetchcover.c:
Added in gettext macros for status messages.
Disabled next button if net_retrieve fails to get any images
from the downloaded xml file (Thanks Daniele).
@@ -83,15 +91,18 @@
2007-06-25 P.G. Richardson <phantom_sf at users.sourceforge.net>
- * display_itdb.h: added tartwork_changed flag to ExtraTrackData
+ * src/display_itdb.h: added tartwork_changed flag to
+ ExtraTrackData
- * details.c: initialise tartwork_changed flag to FALSE. Use this
- flag in details_copy_artwork as additional check if artwork
- has changed. Removal of all tilda related cruff.
+ * src/details.c: initialise tartwork_changed flag to
+ FALSE. Use this flag in details_copy_artwork as additional
+ check if artwork has changed. Removal of all tilda related
+ cruff.
- * fetchcover.c: removal of tilda related cruff with use of the
- tartwork_changed flag from ExtraTrackData. Set Prev Button
- initially to hidden until images from the net are retrieved.
+ * src/fetchcover.c: removal of tilda related cruff with use of
+ the tartwork_changed flag from ExtraTrackData. Set Prev
+ Button initially to hidden until images from the net are
+ retrieved.
2007-06-25 Jorg Schuler <jcsjcs at users.sourceforge.net>
Modified: gtkpod/trunk/src/details.c
===================================================================
--- gtkpod/trunk/src/details.c 2007-06-28 10:46:59 UTC (rev 1608)
+++ gtkpod/trunk/src/details.c 2007-06-29 14:42:54 UTC (rev 1609)
@@ -690,6 +690,7 @@
w = gtkpod_xml_get_widget (detail->xml, buf);
gtk_button_set_label (GTK_BUTTON (w),
gettext (get_t_string (item)));
+ g_free (buf);
break;
default:
buf = g_strdup_printf ("details_label_%d", item);
Modified: gtkpod/trunk/src/display_coverart.c
===================================================================
--- gtkpod/trunk/src/display_coverart.c 2007-06-28 10:46:59 UTC (rev 1608)
+++ gtkpod/trunk/src/display_coverart.c 2007-06-29 14:42:54 UTC (rev 1609)
@@ -1797,9 +1797,9 @@
if (tracks == NULL)
return;
- gchar *album_key;
while (tracks)
{
+ gchar *album_key;
track = tracks->data;
album_key = g_strconcat (track->artist, "_",
track->album, NULL);
@@ -1820,14 +1820,15 @@
/* Insert the new Album Item into the hash */
g_hash_table_insert (album_hash, album_key,
album);
/* Add the key to the list for sorting and
other functions */
- album_key_list = g_list_append (album_key_list,
g_strdup(album_key));
+ album_key_list = g_list_append (album_key_list,
album_key);
}
else
{
- /* Album Item found in the album hash so append
the track to
- * the end of the track list
- */
- album->tracks = g_list_append (album->tracks,
track);
+ /* Album Item found in the album hash so
+ * append the track to the end of the
+ * track list */
+ g_free (album_key);
+ album->tracks = g_list_append (album->tracks,
track);
}
tracks = tracks->next;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
