Revision: 1797
http://gtkpod.svn.sourceforge.net/gtkpod/?rev=1797&view=rev
Author: jcsjcs
Date: 2007-11-16 22:19:50 -0800 (Fri, 16 Nov 2007)
Log Message:
-----------
* src/itdb_playlist.c (itdb_splr_eval): track length in rules for
smart playlists was treated as seconds, but the iPod treats them
as milliseconds. If you told libgpod to create a smart playlist
with tracks less than 100 secs in length, but the life update of
the iPod would interpret that rule as "tracks less than 100 msec
in length", giving a vastly different result. Tested with iPod
Nano 1G and iPod nano Video (3G).
Requires corresponding fix in GUIs using this function.
Modified Paths:
--------------
libgpod/branches/libgpod-0.6/ChangeLog
libgpod/branches/libgpod-0.6/src/itdb_playlist.c
Modified: libgpod/branches/libgpod-0.6/ChangeLog
===================================================================
--- libgpod/branches/libgpod-0.6/ChangeLog 2007-11-17 06:19:21 UTC (rev
1796)
+++ libgpod/branches/libgpod-0.6/ChangeLog 2007-11-17 06:19:50 UTC (rev
1797)
@@ -1,3 +1,15 @@
+2007-11-17 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
+ * src/itdb_playlist.c (itdb_splr_eval): track length in rules for
+ smart playlists was treated as seconds, but the iPod treats them
+ as milliseconds. If you told libgpod to create a smart playlist
+ with tracks less than 100 secs in length, but the life update of
+ the iPod would interpret that rule as "tracks less than 100 msec
+ in length", giving a vastly different result. Tested with iPod
+ Nano 1G and iPod nano Video (3G).
+
+ Requires corresponding fix in GUIs using this function.
+
2007-11-16 Christophe Fergeau <[EMAIL PROTECTED]>
* src/itdb_device.c: fix typoes in iPod Touch model lists
Modified: libgpod/branches/libgpod-0.6/src/itdb_playlist.c
===================================================================
--- libgpod/branches/libgpod-0.6/src/itdb_playlist.c 2007-11-17 06:19:21 UTC
(rev 1796)
+++ libgpod/branches/libgpod-0.6/src/itdb_playlist.c 2007-11-17 06:19:50 UTC
(rev 1797)
@@ -1,5 +1,4 @@
-/* Time-stamp: <2007-02-25 11:52:48 jcs>
-|
+/*
| Copyright (C) 2002-2005 Jorg Schuler <jcsjcs at users sourceforge net>
| Part of the gtkpod project.
|
@@ -424,7 +423,7 @@
handled = TRUE;
break;
case ITDB_SPLFIELD_TIME:
- intcomp = track->tracklen/1000;
+ intcomp = track->tracklen;
handled = TRUE;
break;
case ITDB_SPLFIELD_COMPILATION:
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
