Revision: 2038
          http://gtkpod.svn.sourceforge.net/gtkpod/?rev=2038&view=rev
Author:   teuf
Date:     2008-07-06 07:04:05 -0700 (Sun, 06 Jul 2008)

Log Message:
-----------
Remove non-useful argument to db_parse_context_destroy (patch from songbird)

Modified Paths:
--------------
    libgpod/trunk/ChangeLog
    libgpod/trunk/src/db-artwork-parser.c
    libgpod/trunk/src/db-parse-context.c
    libgpod/trunk/src/db-parse-context.h

Modified: libgpod/trunk/ChangeLog
===================================================================
--- libgpod/trunk/ChangeLog     2008-07-06 12:13:44 UTC (rev 2037)
+++ libgpod/trunk/ChangeLog     2008-07-06 14:04:05 UTC (rev 2038)
@@ -1,5 +1,12 @@
 2008-07-06  Christophe Fergeau <[EMAIL PROTECTED]>
 
+       * src/db-artwork-parser.c
+       * src/db-parse-context.c
+       * src/db-parse-context.h: get rid of unused argument to
+       db_parse_context_destroy (it was always set to TRUE)
+
+2008-07-06  Christophe Fergeau <[EMAIL PROTECTED]>
+
        * src/ithumb-writer.c: fix bug in the function scaling and cropping
        thumbnails, in the non-cropping case, the returned pixbuf size
        didn't reflect the size of the scaled pixbuf
@@ -20,6 +27,8 @@
 
 2008-07-05  Christophe Fergeau <[EMAIL PROTECTED]>
 
+       Patch from: Songbird (http://getsongbird.com/)
+
        * src/ithumb-writer.c: don't leak the list of image formats we get
        from the ItdbDevice
 

Modified: libgpod/trunk/src/db-artwork-parser.c
===================================================================
--- libgpod/trunk/src/db-artwork-parser.c       2008-07-06 12:13:44 UTC (rev 
2037)
+++ libgpod/trunk/src/db-artwork-parser.c       2008-07-06 14:04:05 UTC (rev 
2038)
@@ -706,12 +706,12 @@
        }       
 
        parse_mhfd (ctx, NULL);
-       db_parse_context_destroy (ctx, TRUE);
+       db_parse_context_destroy (ctx);
        return 0;
 
  error:
        if (ctx != NULL) {
-               db_parse_context_destroy (ctx, TRUE);
+               db_parse_context_destroy (ctx);
        }
        return -1;
 }
@@ -779,7 +779,7 @@
                return  -1;
        }
        parse_mhfd (ctx, NULL);
-       db_parse_context_destroy (ctx, TRUE);
+       db_parse_context_destroy (ctx);
 
        /* Now we need to replace references to artwork_ids in the
         * photo albums with references to the actual artwork

Modified: libgpod/trunk/src/db-parse-context.c
===================================================================
--- libgpod/trunk/src/db-parse-context.c        2008-07-06 12:13:44 UTC (rev 
2037)
+++ libgpod/trunk/src/db-parse-context.c        2008-07-06 14:04:05 UTC (rev 
2038)
@@ -59,11 +59,11 @@
 }
 
 void
-db_parse_context_destroy (DBParseContext *ctx, gboolean unmap) 
+db_parse_context_destroy (DBParseContext *ctx) 
 {
        g_return_if_fail (ctx != NULL);
 
-       if (unmap) {
+       if (ctx->buffer != NULL) {
                munmap ((void*)ctx->buffer, ctx->total_len);
        }
        g_free (ctx);

Modified: libgpod/trunk/src/db-parse-context.h
===================================================================
--- libgpod/trunk/src/db-parse-context.h        2008-07-06 12:13:44 UTC (rev 
2037)
+++ libgpod/trunk/src/db-parse-context.h        2008-07-06 14:04:05 UTC (rev 
2038)
@@ -74,6 +74,6 @@
 
 
 G_GNUC_INTERNAL void 
-db_parse_context_destroy (DBParseContext *ctx, gboolean unmap);
+db_parse_context_destroy (DBParseContext *ctx);
 
 #endif


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2

Reply via email to