Revision: 2139
http://gtkpod.svn.sourceforge.net/gtkpod/?rev=2139&view=rev
Author: teuf
Date: 2008-10-08 18:43:20 +0000 (Wed, 08 Oct 2008)
Log Message:
-----------
Fix data sizes used in Itdb_ArtworkFormat
The mostly automated SysInfoExtended parser expects the fields in the
Itdb_ArtworkFormat structure to be of type gint. They used to be of type gin
which led to random overwriting of their value since the parser expected the
to be bigger than they really are.
Modified Paths:
--------------
libgpod/trunk/ChangeLog
libgpod/trunk/src/itdb_device.h
Modified: libgpod/trunk/ChangeLog
===================================================================
--- libgpod/trunk/ChangeLog 2008-10-07 23:37:15 UTC (rev 2138)
+++ libgpod/trunk/ChangeLog 2008-10-08 18:43:20 UTC (rev 2139)
@@ -1,5 +1,13 @@
2008-10-07 Christophe Fergeau <[EMAIL PROTECTED]>
+ * src/itdb_device.h: switch members in Itdb_ArtworkFormat from
+ guint16 to gint since the SysInfoExtended parser will assume
+ they are gint value and will try to write to them through a
+ gint* pointer (ie it will overwrite whatever is around the
+ guint16 value if we don't change it)
+
+2008-10-07 Christophe Fergeau <[EMAIL PROTECTED]>
+
* src/itdb_device.c: fix itdb_device_supports_artwork to properly
take into account data from SysInfoExtended if available
Modified: libgpod/trunk/src/itdb_device.h
===================================================================
--- libgpod/trunk/src/itdb_device.h 2008-10-07 23:37:15 UTC (rev 2138)
+++ libgpod/trunk/src/itdb_device.h 2008-10-08 18:43:20 UTC (rev 2139)
@@ -95,9 +95,9 @@
};
struct _Itdb_ArtworkFormat {
- gint16 format_id;
- gint16 width;
- gint16 height;
+ gint format_id;
+ gint width;
+ gint height;
ItdbThumbFormat format;
gint32 padding; /* not found in SysInfoExtended, added
* for compatibility with hardcoded artwork formats */
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
