commit de862db20558c92f8dd6da46b1ea1a1c27373d46
Author: phantomjinx <[email protected]>
Date: Sat Sep 4 00:08:32 2010 +0100
Removes unnecessary glist length tests for empty glists
* Pointless as an empty glist is null
plugins/cover_display/display_coverart.c | 4 ++--
plugins/media_player/media_player.c | 4 ++--
plugins/photo_editor/display_photo.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/plugins/cover_display/display_coverart.c
b/plugins/cover_display/display_coverart.c
index 7372730..25ee945 100644
--- a/plugins/cover_display/display_coverart.c
+++ b/plugins/cover_display/display_coverart.c
@@ -1753,7 +1753,7 @@ GdkColor *coverart_get_background_display_color() {
gchar *hex_string;
GdkColor *color;
- if (album_key_list == NULL || g_list_length(album_key_list) == 0)
+ if (album_key_list == NULL)
hex_string = "#FFFFFF";
else if (!prefs_get_string_value("coverart_display_bg_color", NULL))
hex_string = "#000000";
@@ -1776,7 +1776,7 @@ GdkColor *coverart_get_foreground_display_color() {
gchar *hex_string;
GdkColor *color;
- if (album_key_list == NULL || g_list_length(album_key_list) == 0)
+ if (album_key_list == NULL)
hex_string = "#000000";
else if (!prefs_get_string_value("coverart_display_bg_color", NULL))
hex_string = "#FFFFFF";
diff --git a/plugins/media_player/media_player.c
b/plugins/media_player/media_player.c
index 512f2a3..dfafbdf 100644
--- a/plugins/media_player/media_player.c
+++ b/plugins/media_player/media_player.c
@@ -300,7 +300,7 @@ static void previous_song() {
if (!player)
return;
- if (!player->tracks || g_list_length(player->tracks) == 0)
+ if (!player->tracks)
return;
player->previousButtonPressed = TRUE;
@@ -318,7 +318,7 @@ static void play_song() {
if (!player)
return;
- if (!player->tracks || g_list_length(player->tracks) == 0)
+ if (!player->tracks)
return;
if (!g_thread_supported ()) {
diff --git a/plugins/photo_editor/display_photo.c
b/plugins/photo_editor/display_photo.c
index e2534d0..36207bc 100644
--- a/plugins/photo_editor/display_photo.c
+++ b/plugins/photo_editor/display_photo.c
@@ -485,7 +485,7 @@ static void gphoto_thumb_selection_changed(GtkIconView
*iconview, gpointer user_
selected_items = gtk_icon_view_get_selected_items(iconview);
- if (selected_items == NULL || g_list_length(selected_items) == 0)
+ if (selected_items == NULL)
return;
model = gtk_icon_view_get_model(iconview);
@@ -1245,7 +1245,7 @@ static void
on_photodb_view_full_size_menuItem_activate(GtkMenuItem *menuItem, g
/* Find which images are selected */
selected_images =
gtk_icon_view_get_selected_items(GTK_ICON_VIEW(photo_editor->thumbnail_view));
- if (selected_images == NULL || g_list_length(selected_images) == 0) {
+ if (selected_images == NULL) {
gtk_tree_model_get_iter_first(model, &iter);
}
else {
@@ -1329,7 +1329,7 @@ static void dnd_images_drag_data_get(GtkWidget *widget,
GdkDragContext *dc, GtkS
/* Find which images are selected */
selected_images = gtk_icon_view_get_selected_items(GTK_ICON_VIEW(widget));
- if (selected_images == NULL || g_list_length(selected_images) == 0)
+ if (selected_images == NULL)
return;
model = gtk_icon_view_get_model(GTK_ICON_VIEW(widget));
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2
