On 6/29/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
Vladimir Gorr wrote: > On 6/29/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote: >> >> >> >> Ivan Volosyuk wrote: >> > On 6/29/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote: >> >> >> >> >> >> Ivan Volosyuk wrote: >> >> > Geir, >> >> > >> >> > I am working on the patch. There is almost no problem, except that >> >> > DRLVM builds its own modified version of eclipse plugin. The plugin >> >> > requires eclipse for its build. >> >> > I see that the same plugin exists in >> >> > enhanced/tools/eclipse/org.apache.harmony.eclipse.jdt.launching. >> >> > I think: >> >> > - all modifications to the plugin should go to this directory. >> >> > - drlvm should not build eclipse plugin itself, it should be built >> >> > as part of tools. >> >> > >> >> > Correct? >> >> >> >> I think so. let me ask... why do we *need* the eclipse plugin to >> build, >> >> and even more important, why must it be modified? >> > >> > The purpose of modifications was AFAIK to make it compactible with the >> > name of main executable: 'ij.exe'. It looks that there were also a few >> > bug fixes. >> >> I can fix the former in about 3 min... :) > > > Did we run the TCK tests for doing this :)? For changing the name of an exe? I'm sure I'm capable of that without needing a testsuite...
Great! We thought slightly else when used 'ij' :). If you will make this thing we need not to forget to correct the patch for the Eclipse plugin: drlvm\trunk\build\patches\hyplugin.patch. I believe it can be removed at all when Tim will look at these changes and take a decision. Thanks, Vladimir. geir
--------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
