Jean Delvare wrote: > Hi Mark, > > On Tue, 21 Oct 2008 19:42:42 +0100, Mark Jackson wrote: >> Jean Delvare wrote: >>> On Tue, 21 Oct 2008 15:55:26 +0100, Mark Jackson wrote: >>>> This patch adds support for the (I2C based) DS28CM00 ID chip. >>>> (v2 after running through checkpatch) >>>> >>>> Signed-off-by: M.Jackson <[EMAIL PROTECTED]> >>>> --- >>>> drivers/i2c/chips/Kconfig | 7 ++ >>>> drivers/i2c/chips/Makefile | 1 + >>>> drivers/i2c/chips/ds28cm00.c | 166 >>>> ++++++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 174 insertions(+), 0 deletions(-) >>> Nack. No new drivers under drivers/i2c/chips please, it's going away >>> soon. >> Okay ... where should any new drivers be located ? > > Depends of what the device does. > * Hardware monitoring chip drivers go to drivers/hwmon > * RTC chip drivers go to drivers/rtc > * I/O expander drivers go to drivers/gpio > If you can't find a suitable directory under drivers, either create a > new one if that makes sense, or put your driver under drivers/misc.
Ah, now I understand !! I think drivers/misc is probably a good a place as any, >>>> +static int ds28cm00_attach_adapter(struct i2c_adapter *adapter); >>>> +static int ds28cm00_detect(struct i2c_adapter *adapter, int address, int >>>> kind); >>>> +static int ds28cm00_detach_client(struct i2c_client *client); >>>> + >>>> +/* This is the driver that will be inserted */ >>>> +static struct i2c_driver ds28cm00_driver = { >>>> + .driver = { >>>> + .name = "ds28cm00", >>>> + }, >>>> + .attach_adapter = ds28cm00_attach_adapter, >>>> + .detach_client = ds28cm00_detach_client, >>>> +}; >>> attach_adapter and detach_client are deprecated. Please use probe and >>> remove instead. >> Are there any existing chip drivers that use this new method ? > > As of 2.6.27-git10: all drivers under drivers/i2c/chips, all i2c > drivers under drivers/gpio, all i2c drivers under drivers/hwmon, all > i2c drivers under drivers/rtc, and more. > > You may want to take a look at Documentation/i2c/upgrading-clients too. Okay ... thanks for the pointer. Mark _______________________________________________ i2c mailing list i2c@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/i2c