Hi Guennadi Liakhovetski
Thank you for checking patch. > > +/* COM3 */ > > +#define SWAP_MASK (BIT_MASK(3) << 3) > > Ohhoh... This equals 0x40. In v3 this used to be > > #define SWAP_MASK (B5|B4|B3) > > i.e., 0x38. Is this a correction? And even if so, why such an "unusual" > form "BIT_MASK(3) << 3"? Doesn't look good:-( Sorry it is my mistake. I'll use 0x38 simply and send v8 patch. > And if the above is indeed a mistake and there's going to be a v8, please, > also remove these empty lines at the very beginning of the above two > functions. I'll remove empty lines. Thank you very mush /Morimoto _______________________________________________ i2c mailing list i2c@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/i2c
