On Thu, 28 Apr 2011 10:06:51 +0800, "Feng, Boqun" <boqun.f...@intel.com> wrote: > I have discussed this with Chris in my earlier patch. > > This change is a clean-up, since ring_put_irq and ring_get_irq are only used > by > bsd_ring_put_irq and bsd_ring_get_irq. > > And once this change is made, it is more clear to see the difference between > g4x and ironlake BSD interrupt control interface, because they are handled in > a single function and they are different at the interrupt mask reg addresss as > well as the interrupt flag
please put important details like that in the commit message; having some way to evaluate the utility of the patch is very important for something which doesn't actually change how the code works. -- keith.pack...@intel.com
pgpuVK3a9n7El.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
