Hi!

> For more examples, see:
> https://rwec.co.uk/x/php-parse-errors/comparison.html
> 
> The patch can be reviewed at: https://github.com/php/php-src/pull/5722

I think this is great, thanks for implementing it!

> I am happy to post a small RFC if people think this requires a vote.
> 
> Any other feedback is welcome.

I personally don't think it requires a vote, as error messages are an
implementation detail and nobody should ever rely on it. Let's wait for
a bit though if somebody argues that it needs an RFC, but otherwise I
think we can merge it.

> (As an aside, the other commonly requested change was to include column
> numbers; this appears to be feasible, but definitely more complex, and
> with potential performance trade-offs. I hope to re-visit this later.)

Column numbers would be awesome too.

-- 
Stas Malyshev
smalys...@gmail.com

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

Reply via email to