I have submitted two bugs regarding this: 22384
<http://rubyforge.org/tracker/index.php?func=detail&aid=22384&group_id=4359&;
atid=16798> and 22385
<http://rubyforge.org/tracker/index.php?func=detail&aid=22385&group_id=4359&;
atid=16798> . I think for now you get less weirdness if you revert my
change below back to
StringFormatter sf = new StringFormatter(scope, "%.15g", new
object[] { self });
But this is still not right. The problem is that the trailing zero is being
added in after the formatting but that a) it should be counted as a
significant digit and b) it is not being picked up when there is an exponent
displayed. I think that the StringFormatter needs to be fiddled with to
sort this out but I am wary of entering into this rather complex beast in
case I break other stuff.
Regards,
Pete
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of John Lam
(IRONRUBY)
Sent: Friday,10 October 10, 2008 23:08
To: [email protected]
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes
You changed this line:
StringFormatter sf = new StringFormatter(scope, "%.15g", new
object[] { self });
To:
StringFormatter sf = new StringFormatter(scope, "%.14g", new
object[] { self });
Why the reduced # of digits? This is causing one of the specs to fail:
1)
Math.sqrt returns the square root of the argument FAILED
Expected "123456789.12346"
to equal "123456789.123457"
Thanks,
-John
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Peter Bacon Darwin
Sent: Thursday, October 09, 2008 12:00 PM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes
Pushed the bug fixes to SVN r160. Someone on MS side needs to look at
ironruby-tags and make sure it is up to date.
Pete
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of John Lam
(IRONRUBY)
Sent: Thursday,09 October 09, 2008 17:17
To: [email protected]
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes
Looks good. Please check into SVN and I'll integrate. Note that I'm pushing
out r159 in a few minutes, so you'll need to update and regenerate the
initializers before you check in.
Thanks,
-John
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Peter Bacon Darwin
Sent: Thursday, October 09, 2008 7:21 AM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes
Thanks Jim. I pulled the latest rubyspecs and there are no unexpected
failures.
Still waiting for someone to review my code...
Pete
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Jim Deville
Sent: Wednesday,08 October 08, 2008 21:44
To: [email protected]
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes
If you are running against the RubySpec's version of RubySpecs (as opposed
to the IronRuby repo) you may want to sync and test again. I pushed some
changes last night that make some of the float comparison do numerical
comparisons instead of string comparisons.
JD
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Peter Bacon Darwin
Sent: Wednesday, October 08, 2008 10:09 AM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes
Ping!
From: Peter Bacon Darwin [mailto:[EMAIL PROTECTED]
Sent: Tuesday,07 October 07, 2008 14:38
To: '[email protected]'
Subject: Code Review (External): NumericalFixes
A number of fixes to pass most of the relevant rubyspecs.
BignumOps.cs: Leftshift and Rightshift fixes
FixnumOps.cs: Leftshift, Rightshift, Bitwise_Xor,
Bitwise_And and Bitwise_Or fixes
FloatOps.cs: Constant and IsNegativeZero modification. Also
partial fix to ToS
Integer.cs: DownTo and UpTo fixes
Numeric.cs: Remainder and Step fixes.
(There are now only 2 failures in Numeric, 1 in Float and a number in
Bignum.)
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core
