Looks good overall. You should probably resort the frexp, hypot and ldexp methods back into alphabetical order.
From: Jim Deville Sent: Tuesday, October 14, 2008 2:50 PM To: Jim Deville; IronRuby External Code Reviewers Cc: [email protected] Subject: RE: Code Review: math Doh, forgot the diff. JD From: Jim Deville Sent: Tuesday, October 14, 2008 2:49 PM To: IronRuby External Code Reviewers Cc: [email protected] Subject: Code Review: math tfpt review "/shelveset:math;REDMOND\jdeville" Comment : Implements most of the missing math methods. Modifies specs around those. Math.erf and Math.erfc are still unimplemented, and all Math methods still don't handle nil or coersion correctly. ~~~~ JD http://blog.jredville.com
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
