[ 
https://issues.apache.org/jira/browse/JEXL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738450#action_12738450
 ] 

Henri Biestro commented on JEXL-67:
-----------------------------------

Any comments on the patch ? it cleans up  the visibility of some methods and 
masks using the Void.class as a signature for 'null' arguments (parameters ie 
formal can not be null).

> Potential NPE in util.introspection.MethodKey
> ---------------------------------------------
>
>                 Key: JEXL-67
>                 URL: https://issues.apache.org/jira/browse/JEXL-67
>             Project: Commons JEXL
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: JEXL-67.patch
>
>
> There are two potential NPEs in util.introspection.MethodKey (discovered by 
> Eclipse)
> isInvocationConvertible
> isStrictInvocationConvertible
> Both methods check for actual == null, but the check is part of a compound 
> and condition so actual may still be null.
> The comments suggest that actual should not be null, so the code should 
> either drop the null check entirely or check it properly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to