[ 
https://issues.apache.org/jira/browse/LANG-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792362#action_12792362
 ] 

Paul Benedict commented on LANG-567:
------------------------------------

Do you want to include the root cause to the IAE? I am not a fan of swapping 
exception types without chaining them.

> ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed types very 
> well
> --------------------------------------------------------------------------------
>
>                 Key: LANG-567
>                 URL: https://issues.apache.org/jira/browse/LANG-567
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> ArrayUtils.addAll(T[] array1, T... array2) does not handle mixed array types 
> very well.
> The stack trace for 
> Number[] st = ArrayUtils.addAll(new Integer[]{1}, new Long[]{2L});
> starts:
> java.lang.ArrayStoreException
>       at java.lang.System.arraycopy(Native Method)
>       at org.apache.commons.lang3.ArrayUtils.addAll(ArrayUtils.java:2962)
> which is not all that obvious.
> It would be a lot clearer if the method threw an IlegalArgumentException or 
> similar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to