[
https://issues.apache.org/jira/browse/CONFIGURATION-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564768#comment-17564768
]
Matt Juntunen commented on CONFIGURATION-817:
---------------------------------------------
Wow! I just wished for something out loud on the mailing list and it magically
happened! Thanks, [~Spoor]!
One thing I was picturing during the upgrade was to remove all of the
unnecessary assertion messages. For example, {{ConfigurationAssert}} line 94
contains the line
{code:java}
assertEquals(expEquals, o1.equals(o2), "Wrong result of equals()");
{code}
The custom assertion message in this case feels like extra noise since the
failure could be traced back to this line in the test anyway, and would most
likely need to be in order to fix the issue. What do you think of removing
these superfluous messages? I think a good starting rule of thumb would be to
remove any message that doesn't include a value from the actual test.
> Upgrade to JUnit 5
> ------------------
>
> Key: CONFIGURATION-817
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-817
> Project: Commons Configuration
> Issue Type: Task
> Components: Build
> Reporter: Rob Spoor
> Priority: Minor
>
> From https://lists.apache.org/thread/ygtkpch0s7nss4vx8xfytwsbnv7mzss9
> {quote}Matt Juntunen - Monday, 4 July 2022 04:40:43 CEST
> Re: [VOTE] Release Apache Commons Configuration 2.8.0 based on RC3
> Thanks, Bruno and Gary!
> Gary,
> I think the unit tests as a whole could use some upgrading. I'm
> picturing a conversion to JUnit 5, during which we could ensure
> compatibility with the latest JDK versions. I'm not sure what to do
> about the javadoc warnings on the generated classes. From the comments
> in the pom, this seems to have been an issue since v2.4.
> Regards,
> Matt J{quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
