garydgregory commented on code in PR #494:
URL: https://github.com/apache/commons-text/pull/494#discussion_r1468036811


##########
src/main/java/org/apache/commons/text/CaseUtils.java:
##########
@@ -32,6 +32,8 @@
  * @since 1.2
  */
 public class CaseUtils {
+    public static final int SPACE_CODEPOINT = 32;

Review Comment:
   Hello @ikaronen-relex 
   Thank you for your PR.
   This constant does not need to be part of the public API.
   Shouldn't the set contain chars from `Character.isSpaceChar()` and/or 
`Charcter.isWhitespace()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to