garydgregory commented on PR #238: URL: https://github.com/apache/commons-cli/pull/238#issuecomment-1967713194
> @garydgregory Made some changes to fix the checkstyle errors, and included all other recent changes to the master branch. Should be green now :) > > Edit: technically speaking, the junit-vintage-engine dependency can now be replaced by junit-jupiter-engine, this would prevent any new old-style tests from being introduced. Not sure if we want to go that way? @DamnedElric Yes, let's please migrate _away_ from the vintage layer. I want to avoid anything non-version 5 from sneaking back in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org