StefanOltmann commented on code in PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#discussion_r1564310655
##########
src/changes/changes.xml:
##########
@@ -48,10 +48,13 @@ The <action> type attribute can be add,update,fix,remove.
<body>
<release version="1.0.0-alpha5" date="YYYY-MM-DD" description="The
1.0.0-alpha5 release requires Java 8.">
<!-- FIX -->
+ <action issue="IMAGING-319" dev="kinow" type="fix" due-to="Stefan
Oltmann, Gary Lucas">
+ Fix EXIF metadata is discarded when updating offsets (wrong
calculation).
+ </action>
<!-- UPDATE -->
<action dev="ggregory" type="update" due-to="Dependabot">Bump
org.apache.commons:commons-parent from 67 to 69 #382.</action>
<action dev="ggregory" type="update" due-to="Dependabot">Bump
commons-io:commons-io from 2.16.0 to 2.16.1 #385.</action>
- <action issue="IMAGING-351" dev="kinow" type="update" due-to="Stefan
Oltmann, Gary Lucas">
+ <action issue="IMAGING-351" dev="kinow" type="update" due-to="Stefan
Oltmann, Gary Lucas, Charles Hope">
Review Comment:
Yes, it’s fair. Charles wrote the first version and did half the job. I
think he did not understand why the offsets changed and lost interest in fixing
his test, but we are a community, so I stepped in. 🙂
Gary was not actually involved in the unit test, but as he is the hero
solving the problem, I’m fine with mentioning him. 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
