[ 
https://issues.apache.org/jira/browse/CONFIGURATION-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146537#comment-13146537
 ] 

Oliver Heger commented on CONFIGURATION-470:
--------------------------------------------

I am sorry, but is this really a problem? On my machine (an almost 4 years old 
laptop) the additional JavaCC step takes about a second; this hardly counts 
compared to some of the tests which take much longer. Eclipse does not have any 
problems with finding the generated sources.

Benefits are that redundant code has been removed and the danger of editing 
generated classes has been minimized.
                
> Extract classes generated by JavaCC
> -----------------------------------
>
>                 Key: CONFIGURATION-470
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-470
>             Project: Commons Configuration
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.7
>            Reporter: Oliver Heger
>            Assignee: Oliver Heger
>            Priority: Minor
>             Fix For: 1.8
>
>
> In the plist package classes generated by JavaCC are used to parse specific 
> configuration files. Currently these files are stored in SVN like regular 
> source files. This does not conform to best practices, is confusing, and 
> requires a special treatment in the configuration of tools like checkstyle or 
> findbugs.
> It would be better to let these files be generated during the build process 
> by the maven JavaCC plug-in. A working configuration can kindly be borrowed 
> from the OGNL component. The additional generation step should not slow down 
> the build significantly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to