[ https://issues.apache.org/jira/browse/SANDBOX-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198666#comment-13198666 ]
Simone Tripodi commented on SANDBOX-379: ---------------------------------------- Just terminated to have a look at the patch, good, few observations before applying it: * {{BeanAccessorTestCase}} has only 1 test method that can be included in {{BeanUtilsTest}}; the {{describes}} is {{protected}} (and there's no reason why), it can be {{private final}}. * Same thing for {{Jira157TestCase}}, test methods can be moved in the {{BeanUtilsTest}} class; methods name have to be renamed stripping the {{testIssue_BEANUTILS_157_BeanUtils}} prefix; * {{AccessibleObjectsRegistry#getMethodsRegistry()}} can be referenced statically in {{PropertyDescriptorsRegistry}}; * {{PropertyDescriptorsRegistry#makeMethodsAccessible}} returns the same {{PropertyDescriptor}} input instance, there's no reason that method has a return statement, signature can be changed to {{void}}. Please modify the patch so I can apply it > [BeanUtils2] Implement describe() on DefaultBeanAccessor > --------------------------------------------------------- > > Key: SANDBOX-379 > URL: https://issues.apache.org/jira/browse/SANDBOX-379 > Project: Commons Sandbox > Issue Type: Improvement > Components: BeanUtils2 > Affects Versions: Nightly Builds > Reporter: Benedikt Ritter > Attachments: SANDBOX-379.txt > > > Implement the above mentioned method an corresponding unit tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira