[ https://issues.apache.org/jira/browse/SANDBOX-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221877#comment-13221877 ]
Simone Tripodi commented on SANDBOX-404: ---------------------------------------- hola, having a look at the patch I am not really happy on how signatures heavily changed, once dropped the {{OrderedMonoid}}, but I can safety live with it. The rename instead doesn't convince me at all: {{Monoid}} perfectly reflects the monoid definition - it is an interface indeed - {{Addition}} is one monoid *instance*. What is we have to add more Monoid operations? Do you intend to create new monoid for each operation? > Simplify weight model > --------------------- > > Key: SANDBOX-404 > URL: https://issues.apache.org/jira/browse/SANDBOX-404 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph > Reporter: Simone Tripodi > Attachments: SANDBOX-404.patch, > SANDBOX-404_gettingRidOfOrderedMonoid.patch > > > As discussed on {{dev@}}, {{Zero}}, {{Semigroup}} and {{Monoid}} can be > merged directly in one single interface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira