DefaultExecutor line 372 swallows IOException cause instead of propagating it
-----------------------------------------------------------------------------

                 Key: EXEC-64
                 URL: https://issues.apache.org/jira/browse/EXEC-64
             Project: Commons Exec
          Issue Type: Bug
    Affects Versions: 1.1
            Reporter: Michael Vorburger
            Priority: Trivial


DefaultExecutor line 372 does:

{noformat}
                } catch (Exception e) {
                    throw new IOException(e.getMessage());
                }
{noformat}

when it may be better to do:


{noformat}
                } catch (Exception e) {
                    throw new IOException(e.getMessage(), e);
                }
{noformat}

This didn't cause any real issues for me - I just came across it as I was 
browsing the Commons Exec source, in the context of implementing a launch 
helper (BTW: see 
https://github.com/vorburger/MariaDB4j/blob/master/src/main/java/ch/vorburger/exec/ManagedProcess.java
 - would that, once further cleaned-up, potentially be something of any 
interest to you for integration into Commons Exec?).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to