[ https://issues.apache.org/jira/browse/SANDBOX-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238156#comment-13238156 ]
Simone Tripodi commented on SANDBOX-416: ---------------------------------------- Good morning! It looks very good, before resolving the issue I suggest to handle the {{ABORT}} state in every method - maybe the user had enough of visiting the graph and evaluated the visit is complete. When {{ABORT}} is detected, it just stop visiting (different from {{SKIP}} that should skip only the subtree) and invokes the {{onCompleted()}}. TIA and well done, -Simo > Improve DFS/BFS visit states > ---------------------------- > > Key: SANDBOX-416 > URL: https://issues.apache.org/jira/browse/SANDBOX-416 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph > Reporter: Simone Tripodi > Assignee: Claudio Squarcella > > As discussed in > [ML|http://mail-archives.apache.org/mod_mbox/commons-dev/201203.mbox/%3CCAAqLGLOhZYC8qvT4TLugsnqCgw9BQ-%2BkYoGXVrKASy7PDZdeoQ%40mail.gmail.com%3E], > {{org.apache.commons.graph.visit.GraphVisitHandler}} methods that return > {{boolean}} flags can be sometimes not so intuitive. > The proposal is replacing {{boolean}} flags return statements with an > enumeration values {{ABORT}}, {{CONTINUE}}, {{SKIP}} to identify > * visit has to be immediately terminated > * visit can continue; > * current node children visit can be skipped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira