[ https://issues.apache.org/jira/browse/LANG-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358344#comment-14358344 ]
Benedikt Ritter commented on LANG-1091: --------------------------------------- Patches welcome! :-) > Shutdown thread pools in test cases > ----------------------------------- > > Key: LANG-1091 > URL: https://issues.apache.org/jira/browse/LANG-1091 > Project: Commons Lang > Issue Type: Improvement > Components: lang.builder.*, lang.concurrent.* > Affects Versions: 4.0 > Environment: Linux, JDK 7 > Reporter: Jesper Öqvist > Original Estimate: 1h > Remaining Estimate: 1h > > The tests, in for example > org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest, create thread > pools which are not shut down properly, leading to idle worker threads that > can prevent the JVM from shutting down properly. > Suggested fix: shutdown() on the thread pool where a call to shutdown or > shutdownNow is missing. > Affected classes (these were the ones I could find easily, I may have missed > some): > * org.apache.commons.lang3.builder.ReflectionToStringStyleConcurrencyTest > * org.apache.commons.lang3.builder.ToStringStyleConcurrencyTest > * org.apache.commons.lang3.concurrent.CallableBackgroundInitializerTest -- This message was sent by Atlassian JIRA (v6.3.4#6332)