[
https://issues.apache.org/jira/browse/DBCP-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz updated DBCP-441:
-----------------------------
Fix Version/s: 2.1.1
> Update DBCP2 configuration web page to add missing properties from
> BasicDataSource API and BasicDataSourceFactory config
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: DBCP-441
> URL: https://issues.apache.org/jira/browse/DBCP-441
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 2.1
> Environment:
> http://commons.apache.org/proper/commons-dbcp/configuration.html
> Reporter: Justin Cranford
> Priority: Minor
> Labels: documentation, easyfix
> Fix For: 2.1.1
>
>
> This web page documents DBCP 2 configuration properties:
> http://commons.apache.org/proper/commons-dbcp/configuration.html
> I compared the listed properties to DBCP 2.1 classes BasicDataSource and
> BasicDataSourceFactory. I noticed 5 configuration properties supported by the
> code which are missing from the DBCP configuration web page. Please add these
> properties to the configuration documentation. Thank you.
> 1) jmxName - mentioned in DBCP-418, supported by both BasicDataSource and
> BasicDataSourceFactory, but not documented on the DBCP configuration web page
> 2) enableAutoCommitOnReturn - mentioned in DBCP-351, supported by both
> BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP
> configuration web page
> 3) rollbackOnReturn - mentioned in DBCP-399 and DBCP-436, supported by both
> BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP
> configuration web page
> 4) validationQueryTimeout - mentioned in DBCP-163 and DBCP-226, supported by
> both BasicDataSource and BasicDataSourceFactory, but not documented on the
> DBCP configuration web page
> 5) defaultQueryTimeout - mentioned in DBCP-340, supported by both
> BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP
> configuration web page
> Note: I also noticed BasicDataSource API supports setAbandonedUsageTracking
> which passes a configuration option to Commons Pool 2. This option is only
> available in BasicDataSource API, not in BasicDataSourceFactory config, so I
> am not sure if it was intentionally left out of BasicDataSourceFactory and
> the DBCP configuration web page.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
