[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting

[Bruno P. Kinoshita (JIRA)]

    [ 
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058343#comment-16058343
 ] 

Bruno P. Kinoshita commented on JEXL-227:
-----------------------------------------

(y) thanks for the explanation Henri!

>From the Javadocs of the parent

{code:java}
    /**
     * Returns the version of the scripting language supported by this
     * <code>ScriptEngine</code>.
     * @return The version of the supported language.
     */
    public String getLanguageVersion();

    /**
     * Returns the version of the <code>ScriptEngine</code>.
     * @return The <code>ScriptEngine</code> implementation version.
     */
    public String getEngineVersion();
{code}

So I think #getEngineVersionmust match the version in pom.xml, and 
#getLanguageVersion should be 3.0, until we introduce version to the language 
that deserve a version bump. Does that sound right?

> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 
> 3.1 as of reporting
> -----------------------------------------------------------------------------------------------
>
>                 Key: JEXL-227
>                 URL: https://issues.apache.org/jira/browse/JEXL-227
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Dmitri Blinov
>            Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine 
> version in 3.1
> {code}
>     public String getEngineVersion() {
>         return "3.0"; // ensure this is updated if function changes are made 
> to this class
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)