czy006 commented on code in PR #21012:
URL: https://github.com/apache/flink/pull/21012#discussion_r1016660433
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java:
##########
@@ -92,12 +92,12 @@ public CompletableFuture<JarRunResponseBody> handleRequest(
@Nonnull final DispatcherGateway gateway)
throws RestHandlerException {
- final Configuration effectiveConfiguration = new
Configuration(configuration);
+ final Configuration effectiveConfiguration = new
Configuration(this.configuration);
effectiveConfiguration.set(DeploymentOptions.ATTACHED, false);
effectiveConfiguration.set(DeploymentOptions.TARGET,
EmbeddedExecutor.NAME);
final JarHandlerContext context =
JarHandlerContext.fromRequest(request, jarDir, log);
- context.applyToConfiguration(effectiveConfiguration);
+ context.applyToConfiguration(effectiveConfiguration, request);
SavepointRestoreSettings.toConfiguration(
getSavepointRestoreSettings(request), effectiveConfiguration);
Review Comment:
fix it. now not use the restFlinkConfig to set it first,it use
effectiveConfiguration to set it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
