luoyuxia commented on code in PR #3864:
URL: https://github.com/apache/fluss/pull/3864#discussion_r3763151667
##########
fluss-server/src/main/java/org/apache/fluss/server/metrics/group/TabletServerMetricGroup.java:
##########
@@ -239,6 +240,20 @@ public Counter failedIsrUpdates() {
return failedIsrUpdates;
}
+ /**
+ * Registers the number of in-flight historical partition requests for an
operation.
+ *
+ * @param operation historical partition operation
+ * @param inflightRequests gauge for accepted requests that have not
completed
+ */
+ public void registerHistoricalPartitionInflightRequests(
+ String operation, Gauge<Integer> inflightRequests) {
+ HistoricalPartitionOperationMetricGroup operationMetricGroup =
+ new HistoricalPartitionOperationMetricGroup(registry, this,
operation);
+ operationMetricGroup.gauge(
+ MetricNames.HISTORICAL_PARTITION_INFLIGHT_REQUESTS,
inflightRequests);
Review Comment:
I was thinking to use operation label for future write metric, but I agree
that we can unify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
