[
https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924096#comment-15924096
]
Bhupendra Kumar Jain commented on HBASE-17779:
----------------------------------------------
V2 patch looks fine to me. I think , we can include this in all branches as
there is no incompatibility introduced for API and behavior change is actually
a bug fix. Whats your opinion [~tedyu]
> disable_table_replication returns misleading message and does not turn off
> repliaton
> ------------------------------------------------------------------------------------
>
> Key: HBASE-17779
> URL: https://issues.apache.org/jira/browse/HBASE-17779
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Janos Gub
> Labels: incompatibleChange
> Attachments: HBASE-17779.patch, HBASE-17779-v2.patch
>
>
> Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns
> families is not replicated.
> Because of this if you have a table where replication is partially enabled,
> calling disable_table_replication will not have any effect, but will report
> that replication for a given table is disabled.
> Workaround is enabling table replication before disabling.
> As a solution quoted from HBASE-17460:
> Admin#disableTableReplication() returns nothing and isTableRepEnabled()
> returns boolean. For master branch, we can let isTableRepEnabled() return
> enum (partially disabled, disabled, etc) This way,
> Admin#disableTableReplication() can return meaningful value to the user.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)