Adarsh-Me commented on PR #3192: URL: https://github.com/apache/hugegraph/pull/3192#issuecomment-5779577228
One correction to what I wrote in the empty-fixture thread: I said `docker-build (hugegraph-server/Dockerfile)` "should go green", and it cannot tell us anything yet — CI has not run on either new commit. Every workflow on `b93b52e` and `bf83032` is sitting at `action_required`, i.e. GitHub is holding the runs for this fork PR until a committer approves them ([Docker Build CI on `bf83032`](https://github.com/apache/hugegraph/actions/runs/35748205479)). Could someone with write access approve the workflows? The last approved run is [35101931936](https://github.com/apache/hugegraph/actions/runs/35101931936), which failed at `test-docker-entrypoint.sh:221` and never reached anything after it. Where the four open findings landed: | finding | fix | case that fails without it | | --- | --- | --- | | copy-back is not failure-safe (`props.awk:240`) | `b93b52e` — 0600 snapshot before the copy, restore on failure, staging files removed only on success | injected `cat` fails the copy; `cmp` against a pristine copy | | `inblk` never cleared (`docker-entrypoint.sh:139`) | `b93b52e` — block closes at the next key at or left of `authentication:`'s column | sibling mapping after the block must return nothing; also checked against the shipped `conf-raft1` yaml | | `AUTHENTICATOR_CLASS` overwritten (`docker-entrypoint.sh:190`) | `b93b52e` — default fills in only when unset | operator value survives / unset still defaults | | empty fixture reds the build (`test-docker-entrypoint.sh:207`) | `b93b52e` — the appends move off `sed -i '$a\...'`, which cannot match an empty file; the fixture is kept because the empty config is a real input | the empty-config case, plus the original line-221 assertion | What I could not execute here, so the approved run is the first real signal for it: my host is Git Bash, and MSYS stdio is text mode (`awk`/`grep` never see a CR byte), `chmod` is a no-op (`stat -c %a` says 644 for a 600 file) and `ln -s` writes a copy instead of linking. The CRLF case, the mode-preservation case and the symlink case therefore had to be neutralised to run the file locally — they exit 0 with those four assertions removed. Everything else, including all four cases added for the findings above, runs and passes locally, three times in a row. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
