Adarsh-Me commented on code in PR #3192: URL: https://github.com/apache/hugegraph/pull/3192#discussion_r4169945787
########## hugegraph-server/Dockerfile: ########## @@ -70,6 +70,9 @@ RUN sed -i "s/^restserver.url.*$/restserver.url=http:\/\/0.0.0.0:8080/g" ./conf/ COPY hugegraph-server/hugegraph-dist/docker/scripts/remote-connect.groovy ./scripts COPY hugegraph-server/hugegraph-dist/docker/scripts/detect-storage.groovy ./scripts COPY hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh . +# props.awk needs no COPY: it ships in the assembly bin/ above, which is also +# where bin/enable-auth.sh finds it. yamlscan.awk serves only the entrypoint. +COPY hugegraph-server/hugegraph-dist/docker/yamlscan.awk . Review Comment: At merge base `83ef9f3` this Dockerfile already had `WORKDIR /hugegraph-server/` (48), `COPY .../docker-entrypoint.sh .` (72), `VOLUME /hugegraph-server` (76) and `CMD ["./docker-entrypoint.sh"]` (82) - so the shadow predates this PR and already covers the entrypoint itself; my only new copy is `yamlscan.awk` (75). Relocating the payload outside the volume is a wider image-layout change; happy to do it here if maintainers want that. ########## hugegraph-server/Dockerfile-hstore: ########## @@ -72,6 +72,9 @@ RUN cd /hugegraph-server/conf/graphs \ COPY hugegraph-server/hugegraph-dist/docker/scripts/remote-connect.groovy ./scripts #COPY hugegraph-server/hugegraph-dist/docker/scripts/detect-storage.groovy ./scripts COPY hugegraph-server/hugegraph-dist/docker/docker-entrypoint.sh . +# props.awk needs no COPY: it ships in the assembly bin/ above, which is also +# where bin/enable-auth.sh finds it. yamlscan.awk serves only the entrypoint. +COPY hugegraph-server/hugegraph-dist/docker/yamlscan.awk . Review Comment: Same for hstore: at merge base `83ef9f3` this file already had `WORKDIR /hugegraph-server/` (46), `COPY .../docker-entrypoint.sh .` (74), `VOLUME /hugegraph-server` (78) and `CMD ["./docker-entrypoint.sh"]` (84), so the entrypoint was already inside the declared volume before this PR added `COPY yamlscan.awk` (77). I can move these helpers under /opt in a follow-up if that is the preferred direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
