bitflicker64 commented on code in PR #568:
URL: https://github.com/apache/hugegraph-doc/pull/568#discussion_r4592050681
##########
content/en/docs/contribution-guidelines/validate-release.md:
##########
@@ -160,13 +154,14 @@ After decompressing `*hugegraph*src.tar.gz`, Do the
following checks:
2. `LICENSE` + `NOTICE` exist and the content is normal; `DISCLAIMER` is
required for historical incubating artifacts
3. **does not exist** binaries (without LICENSE)
4. The source code files all contain the standard `ASF License` header (this
could be done with
- the `Maven-MAT` plugin)
+ the `Maven RAT` plugin)
5. Check whether the `pom.xml` version number of each parent/child module is
consistent (and meet
expectations)
6. Finally, make sure the source code works/compiles correctly
```bash
-# prefer to use/switch to `java 17` for HugeGraph 1.8.0+ (`java 11` for 1.7.0)
for the following operations (compiling/running) (Note: `Computer` only
supports `java >= 11`)
+# Use JDK 17 for HugeGraph 1.8.0 and current Computer source validation.
Review Comment:
Minor: "current Computer source validation" ties the JDK rule to the branch
state, so it goes wrong once Computer moves past Java 17; `computer/pom.xml`
sets `maven.compiler.release` 17 for 1.8.0 and 1.7.0 targets 11. Name the
release instead, for example "Use JDK 17 for HugeGraph 1.8.0, including
Computer 1.8.0 sources", and make the same change to "当前 Computer 源码验证" in
`content/cn/docs/contribution-guidelines/validate-release.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]