[ 
https://issues.apache.org/jira/browse/SUREFIRE-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490699#comment-14490699
 ] 

ASF GitHub Bot commented on SUREFIRE-1152:
------------------------------------------

GitHub user seanf opened a pull request:

    https://github.com/apache/maven-surefire/pull/89

    [SUREFIRE-1152] Support rerunFailingTestsCount for test suites

    Submitted by: Sean Flanigan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/seanf/maven-surefire SUREFIRE-1152

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit d2f16b19ba1bf01e94715e146796929902d2125c
Author: Sean Flanigan <sflan...@redhat.com>
Date:   2015-04-11T01:32:37Z

    [SUREFIRE-1152] Support rerunFailingTestsCount for test suites
    Submitted by: Sean Flanigan

----


> Option rerunFailingTestsCount silently fails with test suites
> -------------------------------------------------------------
>
>                 Key: SUREFIRE-1152
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1152
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 2.18.1
>            Reporter: Sean Flanigan
>         Attachments: flakyproject.zip
>
>
> After a test failure (with {{rerunFailingTestsCount > 0}}), the 
> {{JUnit4*Provider.executeWithRerun}} calls {{execute}} again with a list of 
> the failing {{testMethods}}, but {{JUnit4*Provider.execute}} silently fails 
> to find the requested methods.
> When {{testClass}} is actually a test suite class, it may not contain any 
> methods at all (other than inherited {{java.lang.Object}} methods).  The 
> {{execute}} method iterates through the {{java.lang.Object}} methods, never 
> finds a match for the {{testMethods}}, and silently fails to execute anything.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to