[ 
https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563723#comment-14563723
 ] 

ASF GitHub Bot commented on SUREFIRE-1153:
------------------------------------------

Github user Tibor17 closed the pull request at:

    https://github.com/apache/maven-surefire/pull/94


> Take includes into account when using test/it.test property
> -----------------------------------------------------------
>
>                 Key: SUREFIRE-1153
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
>             Project: Maven Surefire
>          Issue Type: Improvement
>    Affects Versions: 2.18.1
>            Reporter: Tomas Rohovsky
>         Attachments: failsafe-test-parameter.zip
>
>
> Currently test/it.test property overrides includes and excludes parameters. I 
> think that it would be better to take includes into account. Lets have this 
> configuration as an example:
> {code}
> <plugin>
>       <groupId>org.apache.maven.plugins</groupId>
>       <artifactId>maven-failsafe-plugin</artifactId>
>       <version>2.18.1</version>
>       <configuration>
>               <includes>
>                       <include>**/*Test.java</include>
>               </includes>
>       </configuration>
>       <executions>
>               <execution>
>                       <goals>
>                               <goal>integration-test</goal>
>                               <goal>verify</goal>
>                       </goals>
>               </execution>
>       </executions>
> </plugin>
> {code}
> If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will 
> end up with:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test 
> (default) on project failsafe-test-parameter: No tests were executed!  (Set 
> -DfailIfNoTests=false to ignore this error.) -> [Help 1]
> {code}
> Sure, you can specify the class name: {{mvn verify 
> -Dit.test=ExampleTest#testFailsafe}} and it will work. But it is more 
> convenient to not do that.
> A reproducer is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to