[
https://issues.apache.org/jira/browse/DOXIA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385285#comment-16385285
]
Hervé Boutemy edited comment on DOXIA-555 at 3/4/18 6:40 PM:
-------------------------------------------------------------
I'll take away compatibility questions (which are part of some renaming not
done currently...) and see the proposal:
1. o.a.m.doxia.siterenderer.RenderingContext definitely is part of
doxia-site-renderer, to render a Doxia document as part of a site: I don't see
where to put it in Doxia Core, and see its javadoc
http://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/apidocs/org/apache/maven/doxia/siterenderer/DocumentRenderer.html
2. o.a.m.doxia.docrenderer.DocumentRendererContext API is completely different
(see
http://maven.apache.org/doxia/doxia-sitetools/doxia-doc-renderer/apidocs/org/apache/maven/doxia/docrenderer/DocumentRendererContext.html)
and is about metadata for a "document" pdf that collects multiple Doxia
"documents". Here, we should find a clear term for the "document" equivalent to
a site. And I don't see where to put this API in Doxia Core, neither how it
relates to the first API
and finally, on your third point "pas to parsers ... to use for example to
print warning/errors while parsing", we could probably add new methods like
{{get/setSource}} to Parser
http://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/Parser.html
and implement it in AbstractParser
http://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/AbstractParser.html:
I imagine every Parser uses AbstractParser, then the addition in the interface
won't break compatibility
But this is IMHO a good idea to completely decouple from the previous ones =>
I'd propose a separate Jira issue
was (Author: hboutemy):
I'll take away compatibility questions (which are part of some renaming not
done currently...) and see the proposal:
1. o.a.m.doxia.siterenderer.RenderingContext definitely is part of
doxia-site-renderer, to render a Doxia document as part of a site: I don't see
where to put it in Doxia Core, and see its javadoc
http://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/apidocs/org/apache/maven/doxia/siterenderer/DocumentRenderer.html
2. o.a.m.doxia.docrenderer.DocumentRendererContext API is completely different
(see
http://maven.apache.org/doxia/doxia-sitetools/doxia-doc-renderer/apidocs/org/apache/maven/doxia/docrenderer/DocumentRendererContext.html)
and is about metadata for a "document" pdf that collects multiple Doxia
"documents". Here, we should find a clear term for the "document" equivalent to
a site. And I don't see where to put this API in Doxia Core, neither how it
relates to the first API
and finally, on your third point "pas to parsers ... to use for example to
print warning/errors while parsing", we could probably add a new method to
Parser
http://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/Parser.html
and implement it in AbstractParser
http://maven.apache.org/doxia/doxia/doxia-core/apidocs/org/apache/maven/doxia/parser/AbstractParser.html:
I imagine every Parser uses AbstractParser, then the addition in the interface
won't break compatibility
But this is IMHO a good idea to completely decouple from the previous ones =>
I'd propose a separate Jira issue
> Footer overrides for FO/PDF outputs
> -----------------------------------
>
> Key: DOXIA-555
> URL: https://issues.apache.org/jira/browse/DOXIA-555
> Project: Maven Doxia
> Issue Type: New Feature
> Components: Module - FO
> Reporter: Alex O'Ree
> Assignee: Hervé Boutemy
> Priority: Major
> Fix For: 2.0
>
> Attachments: DOXIA-555.patch
>
>
> Related https://issues.apache.org/jira/browse/MPDF-81
> I have a use case where I cannot have the copyright symbol on the bottom of
> generated PDF documents. Currently, it looks like the footer is hard coded
> and cannot be customized.
> http://svn.apache.org/viewvc/maven/doxia/doxia/tags/doxia-1.7/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java?view=markup#l762
> ideally, this should be configurable either properties or better yet, the pdf
> descriptor document (maven-pdf-plugin). This would require a change in the
> schema used for the pdf descriptor
> http://maven.apache.org/xsd/document-1.0.1.xsd
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
