[ 
https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833483#comment-17833483
 ] 

ASF GitHub Bot commented on MRESOLVER-518:
------------------------------------------

cstamas commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549407294


##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/NearestVersionSelector.java:
##########
@@ -126,7 +129,7 @@ private UnsolvableVersionConflictException newFailure(final 
ConflictContext cont
         };
         PathRecordingDependencyVisitor visitor = new 
PathRecordingDependencyVisitor(filter);
         context.getRoot().accept(new TreeDependencyVisitor(visitor));
-        return new UnsolvableVersionConflictException(visitor.getPaths());
+        return new UnsolvableVersionConflictException(null, 
visitor.getPaths());

Review Comment:
   undone





> Improvements for version selector
> ---------------------------------
>
>                 Key: MRESOLVER-518
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-518
>             Project: Maven Resolver
>          Issue Type: New Feature
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Currently Resolver "silently" resolves conflict based on "nearest" strategy, 
> without any assumption about selected version (simply the fact it is "nearer 
> to root" makes it win).
> Extend this logic by ability to fail collection in case of version conflict, 
> version divergence and "version incompatibility" for start. As it may come 
> handy, and user may want to fix the build differently than Maven would.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to