slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550519016
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
- archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
I would like to use only `org.codehaus.plexus.archiver.FileSet`, there is a
method: `getIncludes` so we can drop a using of
`rg.apache.maven.shared.model.fileset.FileSet` at all.
Also dependency to `file-management` can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
