[
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836865#comment-17836865
]
ASF GitHub Bot commented on MCOMPILER-588:
------------------------------------------
slawekjaranowski commented on code in PR #234:
URL:
https://github.com/apache/maven-compiler-plugin/pull/234#discussion_r1564254632
##########
src/test/java/org/apache/maven/plugin/compiler/CompilerTest.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugin.compiler;
+
+import java.io.File;
+
+import org.apache.maven.api.plugin.testing.InjectMojo;
Review Comment:
Please use - `org.apache.maven.plugin.testing.junit5.InjectMojo`
and other from `org.apache.maven.plugin.testing.junit5...`
Package `org.apache.maven.api.plugin.testing` is for Maven 4
> JUnit4 test framework to JUnit5 migration
> -----------------------------------------
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Reporter: Mikhail Deviatov
> Priority: Major
>
> We have JUnit5 test framework for a long time.
> It have modular architecture, good support in IDE and quite fast. It would be
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
